Include password regex for Dashboardsinfo to display to users #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2999 +/- ##
============================================
- Coverage 62.39% 62.32% -0.07%
+ Complexity 3380 3369 -11
============================================
Files 267 267
Lines 19772 19774 +2
Branches 3355 3355
============================================
- Hits 12336 12324 -12
- Misses 5798 5805 +7
- Partials 1638 1645 +7
|
stephen-crawford
approved these changes
Jul 12, 2023
willyborankin
approved these changes
Jul 13, 2023
|
@derek-ho Can you re-base this PR with main? |
Done |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
* add password regex setting onto dashboardsinfo backend call Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 744b5d4)
peternied
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returns Password validation regex setting in the dashboards info API call. This will be used by the front end plugin for validation of the provided password when trying to create users
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.